phuse-org / valtools

Validation framework for R packages used in clinical research and drug development.
https://phuse-org.github.io/valtools/
Other
51 stars 10 forks source link

coverage matrix if no coverage info is included #147

Closed mariev closed 3 years ago

mariev commented 3 years ago

vt_scrape_coverage_matrix currently throws error if coverage details is absent

PR coming shortly

thebioengineer commented 3 years ago

Do we want it to fail when only a few test cases have coverage? Or would it make sense to complain when coverage is missing more clearly. ie: Error: Missing coverage documentation for test cases 2, 5, and 25

mariev commented 3 years ago

Well I don't think that an org's choice to be sparse/incomplete with their coverage should block creating the coverage matrix - we actually run across this in {scharpbama} with Process_Test_Cases_Setup.Rmd

Not sure how annoying having a warning would be either 😬

thebioengineer commented 3 years ago

good point.

mariev commented 3 years ago

closed via #149