phuse-org / valtools

Validation framework for R packages used in clinical research and drug development.
https://phuse-org.github.io/valtools/
Other
51 stars 10 forks source link

Validation packets #181

Closed thebioengineer closed 3 years ago

thebioengineer commented 3 years ago
thebioengineer commented 3 years ago

on review of the hex behavior. maybe we move the cheat sheet into man/figures?

thebioengineer commented 3 years ago

I see vt_use_validation() as adding validation infrastructure to existing packages or existing folders. vt_create_* makes the project or package with the infrastructure existing (by calling vt_use_validation under the hood during project or package creation)

mariev commented 3 years ago

I agree, there is a nuanced difference between starting a project w/ validation in mind vs adding validation post-hoc. I am wondering if {valtools} needs to name that difference or we can present the different use cases as equally valid approaches to starting validation? What is the value-add for the users to split creating a packet (adds validation framework to a designated location) vs adding validation to an existing package (adds validation framework to a designated location)? And how do we make that value-add immediately obvious?

thebioengineer commented 3 years ago

Part of it is also for separation of function purposes - so we can share the logic of creating the validation infrastructure (via vt_usevalidation) to concepts existing in usethis::create