search

phuse-org / valtools

Validation framework for R packages used in clinical research and drug development.
https://phuse-org.github.io/valtools/
Other
51 stars 10 forks source link

Testing figure comparisons #185

Closed thebioengineer closed 2 years ago

thebioengineer commented 3 years ago

Vignette on how to perform figure comparisons within {valtools}

thebioengineer commented 3 years ago

Interesting, Yeah, we can chat about that!

thebioengineer commented 3 years ago

@mariev - can you approve the PR then, or did you want to wait to chat?

thebioengineer commented 3 years ago

Looks good! 👍 Wondering if it is worth a convo about compare_file_binary' vs 'compare_file_text for cross-platform compatibility ? SCHARP is running into this issue lately

so the file comparison via compare_file_binary() are working on windows, but failing on the unix os? but compare_file_text() works? that seems strange to me

thebioengineer commented 3 years ago

@mariev - see my two new additions. If you are on board, we can add the suggestions and merge this branch in.

mariev commented 3 years ago

thanks for making these changes - 👍 from me