search

phuse-org / valtools

Validation framework for R packages used in clinical research and drug development.
https://phuse-org.github.io/valtools/
Other
51 stars 10 forks source link

print file content #77

Closed thebioengineer closed 3 years ago

thebioengineer commented 3 years ago

Add internal functions for printing file contents sans roxygen./yaml headers. Should make it simpler for building the vignette in the vt_use_report() function being built in #45

thebioengineer commented 3 years ago

passes all checks locally, and know prints out nicely. Trick was to set the chunk option to 'asis' and cat as opposed to print.

thebioengineer commented 3 years ago

What do you mean by being concerned about absolute file paths? Everything is relative to vt_path()

mariev commented 3 years ago

file paths structured as requirements/example_req.md

thebioengineer commented 3 years ago

ah, i see. yeah, we could make vt_file more like add_file so just the filename is passed as opposed to the location. I was thinking writing it this way mean more flexibility, but now that I think about it, that might not be good

mariev commented 3 years ago

I would just update to using file.path in the tests cases? I believe the existing functions will work regardless of whether users are following good programming practices

thebioengineer commented 3 years ago

Hey Marie, I think your issues have now all been addressed?