phuse-org / valtools

Validation framework for R packages used in clinical research and drug development.
https://phuse-org.github.io/valtools/
Other
51 stars 10 forks source link

test fails due to smart quotes #85

Closed mariev closed 3 years ago

mariev commented 3 years ago

Locally, test_report_rendered from test-add_file.R is failing due to presence of smart quotes not interpreting. This may be my system specific?? Any ideas re: cause?

==> devtools::test()

Loading valtools
Testing valtools
v |  OK F W S | Context
x |  14 1     | add_file [5.6 s]                                                                                               
-------------------------------------------------------------------------------------------------------------------------------
Failure (test-add_file.R:236:3): added files and then rendered report is as expected
`test_report_rendered` not equal to c(...).
1/12 mismatches
x[6]: "print('hello')"
y[6]: "print(�hello�)"
Backtrace:
 1. withr::with_tempdir(...) test-add_file.R:236:2
 4. testthat::expect_equal(...) test-add_file.R:309:4
mariev commented 3 years ago

also affects test-vt_file.R:439:3 and test-vt_file.R:510:3

thebioengineer commented 3 years ago

fixed in develop.