Include add_before and add_after in new item functions

phuse-org / valtools

Validation framework for R packages used in clinical research and drug development.

https://phuse-org.github.io/valtools/

Other

51 stars 10 forks source link

Include add_before and add_after in new item functions #91

Closed elimillera closed 3 years ago

elimillera commented 3 years ago

This PR adds the add_file_to_config functionality and adds the parameters add_before and add_after to be passed into the before and after parameters of add_file_to_config.

I'm not sure what the plans are for merging things in but I can start working off this branch to add 'tidy_select' functionality if I'm on the right track.

Closes #66

thebioengineer commented 3 years ago

there are tests failing now that were explicitly adding the files into the validation.yml! haha. at least we know if works!!

elimillera commented 3 years ago

Yep! I'm working on those now. Should be ready by end of today

elimillera commented 3 years ago

Hey @thebioengineer, I had some trouble with the tests. I think my VM must have a weird pdf render because I get a lot of errors on my machine. But they are passing here so it should be good to merge for now.

mariev commented 3 years ago

@elimillera did pulling branch develop address the pdf build errors on your side? we are temporarily blocked from gh-actions due to https://github.com/r-lib/actions/issues/280 but no errors when I run devtools::check locally