phuse-org / valtools

Validation framework for R packages used in clinical research and drug development.
https://phuse-org.github.io/valtools/
Other
51 stars 10 forks source link

Handling of NEWS details #93

Closed mariev closed 3 years ago

mariev commented 3 years ago

Historically SCHARP has used the NEWS file to capture changelog info tied to a package release. Specifically, we identify release bullets using [validation] and [version date] and scrape those elements only. How should we handle this in {valtools} to be mindful of access differences in the validate on install vs validate after install paradigms?

In order for validation report to render from /inst this file would need to be copied over, and I am hesitant to suggest copying of files that are part of the normal R package structure. Can we use the NEWS formatting, but call this something different, which will then live in the validation working directory?

thoughts? @thebioengineer @elimillera

thebioengineer commented 3 years ago

Change history documentation is pretty standard everywhere I have worked - and we should provide an avenue for it. The idea of creating a "change log" within the validation folder makes sense IMO (keeping news.md structure)

mariev commented 3 years ago

Listing all the functions that would be affected by this change, all test cases are in test-news_handlers.R

mariev commented 3 years ago

@elimillera if you could weigh in, I'll jump on this pretty quickly b/c it is a blocker for the validation report templating

thebioengineer commented 3 years ago

resolved as of #95, reopen if not the case.