Logical bug in VHRroutine

phuselab / pyVHR

Python framework for Virtual Heart Rate

http://phuselab.di.unimi.it/

GNU General Public License v3.0

461 stars 128 forks source link

Logical bug in VHRroutine #47

Closed jo-ym closed 1 year ago

jo-ym commented 2 years ago

Hi, we want to cite this project so we research it. But we found there may be a logical bug in the ./pyVHR/realtime/VHRroutine.py. The block of if-statement, line 192. The counting method will count one more frame to the sig_stride (fps)? So the number of the windows will be not correct.

giulianogrossi commented 1 year ago

A new version of the framework, pyVHR 2.0, has been released. Please check if problems persist and report them for future bug fixes.

best the pyVHR team