phuselab / pyVHR

Python framework for Virtual Heart Rate
http://phuselab.di.unimi.it/
GNU General Public License v3.0
461 stars 128 forks source link

There are two implementations of the Welch() function, which causes confusion. #69

Open ahn19 opened 1 year ago

ahn19 commented 1 year ago

The following error occurred while executing pyVHR_demo_deep.py.

"TypeError: Welch() takes 2 positional arguments but 5 were given"

This is the confusion caused by the implementation of two Welch() functions. The Welch() function was implemented in BPM/utils.py and extraction/utils.py respectively, which caused confusion.

adriano-op commented 1 year ago

This error still persists

ccclu commented 1 year ago

agree