search

phusion / baseimage-docker

A minimal Ubuntu base image modified for Docker-friendliness
http://phusion.github.io/baseimage-docker/
MIT License
8.96k stars 1.09k forks source link

Change container builder from Docker to Buildah/Podman #606

Open peterlobster opened 2 years ago

peterlobster commented 2 years ago

Details

There has been a recent trend moving away from Docker's original tooling, in favor of tooling with better OCI support. My suggestion is to update the tooling for building this container to something that could be either compatible with both Docker and OCI tooling (like Podman) or to add an option to use something like Buildah to build an OCI compatible container image.

Currently, the container is being built with Docker and fails to build with Podman (when using Podman-Docker aliasing).

samip5 commented 2 years ago

Could you please share the errors you encounter when trying to build with Podman?

peterlobster commented 2 years ago 
$ alias docker=podman && make build BASE_IMAGE=registry.hub.docker.com/library/debian:stable NAME=phusion/debian-baseimage-docker
podman build --no-cache -t phusion/debian-baseimage-docker:focal-1.0.0-pre --build-arg BASE_IMAGE=registry.hub.docker.com/library/debian:stable --build-arg QEMU_ARCH=amd64 --platform 
Error: flag needs an argument: --platform
make: *** [Makefile:26: build] Error 125
github-actions[bot] commented 2 years ago

This Issue has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thanks for the feedback.

github-actions[bot] commented 2 years ago

Due to the lack of activity in the last 5 days since it was marked as "stale", we proceed to close this Issue. Do not hesitate to reopen it later if necessary.

samip5 commented 2 years ago 
$ alias docker=podman && make build BASE_IMAGE=registry.hub.docker.com/library/debian:stable NAME=phusion/debian-baseimage-docker
podman build --no-cache -t phusion/debian-baseimage-docker:focal-1.0.0-pre --build-arg BASE_IMAGE=registry.hub.docker.com/library/debian:stable --build-arg QEMU_ARCH=amd64 --platform 
Error: flag needs an argument: --platform
make: *** [Makefile:26: build] Error 125

You seem to be missing an argument, and thus it fails but unfortunately it's been a while since I have tried to build it via make, and should probably update it. It however should currently work when you pass in --platform amd64 for example.