search

phusion / passenger-docker

Docker base images for Ruby, Python, Node.js and Meteor web apps
MIT License
2.78k stars 408 forks source link

Add Gihub Action to run make build_all #335

Closed taleh007 closed 2 years ago

taleh007 commented 2 years ago

Why

In some cases running make build_all take a lot of time and cannot be finished with success (ex. Apple Silicon).

What

Lets have free to use GH-action that will starts on every push to master branch or on every push to PR into master

taleh007 commented 2 years ago

@CamJN I guess it will be nice enhancement for you, no more manual run of make build_all for each PR

taleh007 commented 2 years ago

@CamJN -- it will work after merge, u can see it here https://github.com/taleh007/passenger-docker/actions

CamJN commented 2 years ago

@taleh007 Yeah, as you can see in the https://github.com/taleh007/passenger-docker/runs/4853986640?check_suite_focus=true output, there are no containers running when the purge containers step is run, so i was wondering what it is there for?

taleh007 commented 2 years ago

@CamJN you are right, because it was special branch with wrong files to test how it will fail. And branch 'fail-ci', look at add-ci branch

taleh007 commented 2 years ago

@CamJN did you have a chance to validate that everything is ok?

CamJN commented 2 years ago

@taleh007 in the add-ci branch, the purge containers step still isn't doing anything: https://github.com/taleh007/passenger-docker/runs/4853314745?check_suite_focus=true

taleh007 commented 2 years ago

@CamJN yes, this isteps needs smtimes to be sure there are no other running instances at the same time. (Had some bugs related to it in another project) We can safely delete it

CamJN commented 2 years ago

Actually, that's all I wanted: the reasoning behind it. I'm happy with your answer, no need to remove.