phusion / passenger-docker

Docker base images for Ruby, Python, Node.js and Meteor web apps
MIT License
2.78k stars 408 forks source link

Update JRuby point releases #370

Closed ajhodgson closed 1 year ago

ajhodgson commented 1 year ago
CamJN commented 1 year ago

Can you try to add a conditional to the .github/workflows/main.yml file to only run the image publication steps if the user has permission to publish to ghcr? That's where the checks are failing.

ajhodgson commented 1 year ago

Can you try to add a conditional to the .github/workflows/main.yml file to only run the image publication steps if the user has permission to publish to ghcr? That's where the checks are failing.

Would you prefer:

if: ${{ github.actor }} == "CamJN"

... or

if: ${{ github.event.pull_request.merged }} && ${{ github.ref }} == 'refs/heads/master'

??

I don't see any way of testing ghcr permissions explicitly.

Nor do I have any way of fully testing either solution.

CamJN commented 1 year ago

Let's go with the latter, one of my colleagues might want to run the script at some point.