danowar2k
commented
2 years ago Sorry, my comments were made on the wrong issue. I'll just copy them over here...
Additional info:
On Solaris 11, pid_t is defined in /usr/include/sys/types.h as an int (see https://docs.oracle.com/cd/E86824_01/html/E54772/types.h-3head.html)
I don't know if Passenger includes that on Solaris or if that is some Solaris-special snowflake place.
Maybe the problem is that the getpid() function declaration is unclear as to what getpid() returns...hmm.
Another instance where the same error basically happens later:
In file included from src/agent/Core/SpawningKit/SmartSpawner.h:62:0,
from src/agent/Core/SpawningKit/Factory.h:30,
from src/agent/Core/ApplicationPool/Context.h:33,
from src/agent/Core/ApplicationPool/Common.h:40,
from src/agent/Core/ApplicationPool/Pool.h:62,
from src/agent/Core/Controller/Request.h:37,
from src/agent/Core/Controller/Client.h:32,
from src/agent/Core/Controller.h:83,
from src/agent/Core/TelemetryCollector.h:45,
from src/agent/Core/Config.h:47,
from src/agent/Watchdog/Config.h:32,
from src/agent/Watchdog/WatchdogMain.cpp:68:
src/agent/Core/SpawningKit/Exceptions.h: In member function ‘Passenger::Json::Value Passenger::SpawningKit::SpawnException::inspectSubprocessDetailsAsJson() const’:
src/agent/Core/SpawningKit/Exceptions.h:1057:34: error: conversion from ‘pid_t {aka long int}’ to ‘Passenger::Json::Value’ is ambiguous
doc["pid"] = getSubprocessPid();Maybe I should reevaluate my approach and just try to flee to RHEL.
CamJN
Issue report
After a local patch fixing my last issue https://github.com/phusion/passenger/issues/2440, the next error I encounter is the following (excerpt of the build output):
I limited the output above to the error in question, the other warnings don't seem pertinent to that error. Of course I can always post/attach the whole log if necessary.
Question 1: What is the problem?
What is the expected behavior? Hooks.o should have been compiled with no errors.
What is the actual behavior?
The above error. It looks like the line https://github.com/phusion/passenger/blob/stable-6.0/src/cxx_supportlib/WatchdogLauncher.h#L333 is the problem. getpid() returns an ambiguous pid_t structure which is probably a Solaris problem again ...? Anyway, the compiler doesn't know what pid_t is supposed to be at that time (or it looks like it anyway). So it doesn't know which overloaded function to call. The object at least compiled when I cast pid_t to an integer (or an unsigned integer), but of course I don't know if this could be a fix:
Question 2: Passenger version and integration mode:
Passenger open source 6.0.14 running on Ruby 2.3.8 (yeah, sorry, I'm trying to fix this right now) against a self-compiled 32 Bit Apache httpd 2.4.53 to build mod_passenger.
Question 3: OS or Linux distro, platform (including version):
Solaris 11.4 Release, x86_64
Question 4: Passenger installation method:
Your answer: [x] RubyGems + Gemfile (Gemfile.local for Redmine 3.3.0)
Question 5: Your app's programming language (including any version managers) and framework (including versions):
Ruby 2.3.8 without RVM, Rails 4.2.6
Question 6: Are you using a PaaS and/or containerization? If so which one?
No containerization. Using Vagrant 2.2.16 + VirtualBox 6.1.22 plus private Vagrant boxes.
Question 7: Anything else about your setup that we should know?
No, I think.