phusion / passenger

A fast and robust web server and application server for Ruby, Python and Node.js
https://www.phusionpassenger.com/
MIT License
4.99k stars 548 forks source link

getgrouplist() isn't portable #910

Closed FooBarWidget closed 10 years ago

FooBarWidget commented 10 years ago

From grimjacck on November 09, 2012 17:04:24

What steps will reproduce the problem? 1. Try to build passenger 4 beta on Solaris 2. 3. What is the expected output? What do you see instead? g++ -Iext -Iext/common -Iext/libev -D_REENTRANT -I/usr/local/include -DHASH_NAMESPACE="gnu_cxx" -DHASH_MAP_HEADER="<ext/hash_map>" -DHASH_MAP_CLASS="hash_map" -DHASH_FUN_H="<ext/hash_fun.h>" -pthreads -D__EXTENSIONS -DSOLARIS -D _FILE_OFFSET_BITS=64 -DBOOST_HAS_STDINT_H -DHAS_ALLOCA_H -DHAS_SFENCE -DHAS_LFENCE -Wall -Wextra -Wno-unused-parameter -Wno-parentheses -Wpointer-arith -Wwrite-strings -Wno-long-long -ggdb -DPASSENGER_DEBUG -DBOOST_DISABLE_ASSERTS -fcomm on -o libout/common/libpassenger_common/ApplicationPool2/Implementation.o -c ext/common/ApplicationPool2/Implementation.cpp In file included from ext/common/ApplicationPool2/Group.h:41, from ext/common/ApplicationPool2/Pool.h:42, from ext/common/ApplicationPool2/Implementation.cpp:28: ext/common/ApplicationPool2/Spawner.h: In member function void Passenger::ApplicationPool2::Spawner::prepareUserSwitching(Passenger::ApplicationPool2::Spawner::SpawnPreparationInfo&, const Passenger::ApplicationPool2::Options&) const': ext/common/ApplicationPool2/Spawner.h:788: error:getgrouplist' undeclared (first use this function) ext/common/ApplicationPool2/Spawner.h:788: error: (Each undeclared identifier is reported only once for each function it appears in.) In file included from ext/common/ApplicationPool2/Pool.h:42, from ext/common/ApplicationPool2/Implementation.cpp:28: Please use labels and text to provide additional information.

Original issue: http://code.google.com/p/phusion-passenger/issues/detail?id=811

FooBarWidget commented 10 years ago

From honglilai on November 14, 2012 03:38:16

This should be solved in commit e987ce9. Could you confirm?

Labels: Milestone-4.0.0

FooBarWidget commented 10 years ago

From honglilai on December 08, 2012 02:58:30

Marking it as fixed for now unless I hear otherwise.

Status: Fixed