phuslu / log

Fastest structured logging
MIT License
672 stars 44 forks source link

清理旧备份时,匹配备份文件名称没有关联TimeFormat配置.可造成旧备份未被清理 #16

Closed dotwoo closed 3 years ago

dotwoo commented 3 years ago
# file.go:175
        ext := filepath.Ext(filename)
        pattern := filename[0:len(filename)-len(ext)] + ".20*" + ext
        if names, _ := filepath.Glob(pattern); len(names) > 0 {
            sort.Strings(names)
            for i := 0; i < len(names)-backups-1; i++ {
                os.Remove(names[i])
            }
        }
    }(oldfile, w.file.Name(), w.Filename, w.MaxBackups, w.ProcessID)
phuslu commented 3 years ago

嗯,https://github.com/phuslu/log/commit/3de0291471c22cfb6a44a2b80214e5dbea686499 已经改了,但是好像没打 tag,我发布下

phuslu commented 3 years ago

好了, go get -v -u github.com/phuslu/log@master 就能升级到 v1.0.52 了

phuslu commented 3 years ago

啊,搞错意思了,原来是不想误清理旧有格式。我重新提交了一个 https://github.com/phuslu/log/commit/154a9a9a91019c44a13690b284d06f781a4d304e

这下请 go get -v -u github.com/phuslu/log@master 试下。

phuslu commented 3 years ago

v1.0.53 已经修复。