Closed fireflycons closed 6 months ago
thanks! will go through it today!
Out of interest, what reference did you use to craft the ASM to get the go-id?
I added comment to goid.s
, using pure asm to impalement this function can minimalized the function call overhead in go, I think.
After consideration I thin it's no problem for adding the "TimeUTC" field.
Let me merge it first, thanks.
Another option is change TimeUTC bool
to TimeLocation *time.Location
.
If user give a non-nil value(e.g. Time.UTC), we will call Time.In for the timestamp, and we also need implement a fast path for time.UTC.
@fireflycons please take a look this approach https://github.com/phuslu/log/pull/66 if you have time, thanks.
Perhaps I'm missing something, but I could not see how to get the header timestamp to be always UTC instead of system local time.
This PR adds a boolean field to
Logger
so that UTC may be enabled, and the logic for this inheader()
Additionally fix a typo in
Logger
comments and disable running of syslog tests on Windows.