Closed AronNovak closed 5 years ago
I have the same problem (using ffmpeg to save as GIF).
Same here with Peek 1.3.1 / ffmpeg 4.1-1 from debian sid.
I also use I3 + compton
Same error on Gentoo, glibc 2.28, peek 1.3.1, ffmpeg 4.1.1
I can't reproduce this here. Could be a vala issue, what version of vala are you using?
@phw
Available Packages
Name : vala
Version : 0.42.5
Release : 1.fc29
Architecture : i686
Size : 2.0 M
Source : vala-0.42.5-1.fc29.src.rpm
Repository : updates
Summary : A modern programming language for GNOME
URL : https://wiki.gnome.org/Projects/Vala
License : LGPLv2+ and BSD
Description : Vala is a new programming language that aims to bring modern
: programming language features to GNOME developers without imposing any
: additional runtime requirements and without using a different ABI
: compared to applications and libraries written in C.
:
: valac, the Vala compiler, is a self-hosting compiler that translates
: Vala source code into C source and header files. It uses the GObject
: type system to create classes and interfaces declared in the Vala
: source code. It's also planned to generate GIDL files when gobject-
: introspection is ready.
:
: The syntax of Vala is similar to C#, modified to better fit the GObject
: type system.
Name : vala
Version : 0.42.5
Release : 1.fc29
Architecture : x86_64
Size : 1.8 M
Source : vala-0.42.5-1.fc29.src.rpm
Repository : updates
Same here on Debian sid: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=926386
@hosiet
Confirmed on Mageia 7 (Cauldron) with the distro packaging for 1.3.1, built from source. Using GTK+ 3.24.7, vala 0.44.3 and ffmpeg 4.1.3.
Works for me on these versions: glibc-2.28-r4:2.2 vala-0.36.15:0.36 ffmpeg-4.1.3:0/56.58.58 peek-1.3.1-r2:0
Bug reproduced when update vala to vala-0.42.6.
I suspect it is something wrong in compilation. I install peek-1.3.1-r2 from emerge. The bug can be reproduced. My make.conf:
COMMON_FLAGS="-O2 -pipe -ggdb"
CFLAGS="${COMMON_FLAGS}"
CXXFLAGS="${COMMON_FLAGS}"
FCFLAGS="${COMMON_FLAGS}"
FFLAGS="${COMMON_FLAGS}"
# NOTE: This stage was built with the bindist Use flag enabled
PORTDIR="/usr/portage"
DISTDIR="/usr/portage/distfiles"
PKGDIR="/usr/portage/packages"
# This sets the language of build output to English.
# Please keep this setting intact when reporting bugs.
LC_MESSAGES=C
MAKEOPTS="-j4"
USE="-qt5 -qt4 -kde gtk python X systemd gnome ssl abi_x86_64 -openrc -libressl debugsyms installsources alsa"
PYTHON_TARGETS="python2_7 python3_6"
PYTHON_SINGLE_TARGET="python3_6"
FEATURES="ccache nostrip"
ACCEPT_KEYWORDS="~amd64"
CCACHE_SIZE="3G"
GRUB_PLATFORMS="efi-64 pc"
PORTAGE_NICENESS=19
GENTOO_MIRRORS="http://mirrors.163.com/gentoo/ https://mirrors.tuna.tsinghua.edu.cn/gentoo"
While I build peek-1.3.1 from source, the bug cannot be reproduced. Build steps:
git clone https://github.com/phw/peek.git
mkdir peek/build
cd peek/build
cmake -DCMAKE_INSTALL_PREFIX=/usr -DGSETTINGS_COMPILE=OFF ..
make
@phw
Same on OpenSuse Tumbleweed 20190402
Same on Ubuntu Disco Dingo
(19.04
).
Confirmed on Debian 10 with the distro packaging for 1.3.1, built from source. Using vala 0.44.3 and ffmpeg 4.1.3.
Hello, please have a look at debian bug#926386, message 19 again. There I received a backtrace with all debug symbols. Unfortunately the patch got just applied to the debian package but upstream seems got no notification of this.
Are there any workarounds at this time for Ubuntu 19.04 users?
On Ubuntu 19.04, I've found I can run peek, do the recording, then when it dumps, it leaves behind a valid webm file in the cache. You can either use the webm or convert it using ffmpeg to gif... Note that Ubuntu 19.04 updated 10-May-2019 and may have effected this.
$ peek
Recording to file /home/bob/.cache/peek/peekFMXU1Z.webm
ffmpegfree(): double free detected in tcache 2
Aborted (core dumped)
$ ffmpeg -i /home/bob/.cache/peek/peekFMXU1Z.webm -pix_fmt rgb24 output.gif
This was also reported in Debian GNU/Linux for the gnuplot
package, in bug 926658, and that ticket says it was fixed in Debian:
[6ddeb7e] Fix incomplete/unsafe initialization of ARGV array. (Closes: #926658)
It's a Debian-specific fix that is apparently not (yet) present anywhere in the upstream repository. It is mentioned in the Debian ChangeLog for the gnuplot package, and the Debian Developer Information Page for gnuplot links to corresponding Debian gnuplot maintenance team repository, in which we can find commit 6ddeb7e on the experimental
branch. The change is fairly small. I don't know if it has been submitted upstream or not.
I hope this helps.
For convenience, here's the corresponding Debian patch for peek
(as mentioned earlier by @bernhardu):
On Ubuntu 19.04, I've found I can run peek, do the recording, then when it dumps, it leaves behind a valid webm file in the cache. You can either use the webm or convert it using ffmpeg to gif... Note that Ubuntu 19.04 updated 10-May-2019 and may have effected this.
Wow! You are quite right. Not even have I got the .webm files there, but also PNG and the converted GIF resides in the cache folder itself. It just hasn't been moved to the folder it was supposed to :slightly_smiling_face:
Seems to have been fixed in Debian. Just tried the .deb file from stretch-backports in 19.04 and I have no problem saving the GIFs now.
Seems to have been fixed in Debian. Just tried the .deb file from stretch-backports in 19.04 and I have no problem saving the GIFs now.
Thanks, I had the same Issue with Ubuntu 19.04 and using the version of Peek you linked works for me. :smile: my error:
Using screen recorder backend gnome-shell
Recording to file /home/abezuska/.cache/peek/peekNK5S3Z.webm
free(): double free detected in tcache 2
Aborted (core dumped)
@bernhardu You seem to be the author of the Debian patch that fixes this bug. Would you make a Pull Request so that it can be easily integrated upstream?
You seem to be the author of the Debian patch that fixes this bug. Would you make a Pull Request so that it can be easily integrated upstream?
Thought that would/should go through the debian maintainer @hosiet. Just created a pull request now.
Fixed by #449, could be closed.
This is still happening on the latest version 1.3.1
:cry:
Is there any particular reason why this has not been released?
Same here, a release with this fix would be really nice, since its broken rn.
1.3.1 released one year ago... flathub not updated, is anyone here is the maintainer ?