phw / peek

Simple animated GIF screen recorder with an easy to use interface
GNU General Public License v3.0
10.25k stars 319 forks source link

mouse/interaction with recording area on i3 #52

Closed djcas9 closed 7 years ago

djcas9 commented 7 years ago

Example: Recording a form and clicking the submit button is not possible outside of using the keyboard.

Any plans to support something like this. I'm currently reading over the code to see how complex it would be to contribute.

Thanks for a great project.

phw commented 7 years ago

Do you mean when clicking into the recording area does not allow you to interact with the application behind Peek? This is absolutely supposed to work, if not it is a bug.

At issue #12 some people are reporting this does not work under i3. But it could also be related to the Gtk version used.

What desktop environment and window manager are you using? Which version of Gtk?

djcas9 commented 7 years ago

@phw ah, makes sense. I am using i3. I'll look into it and see if I can figure it out and submit a PR.

djcas9 commented 7 years ago

@phw gtk 3.22.4-1

ibrahima commented 7 years ago

I'm experiencing this with AwesomeWM+Compton, on 3.18.9-1ubuntu3.1 (Ubuntu 16.04, fully patched).

My suspicion is that the way tiling managers work and/or the interaction with Compton is preventing the clicks from going through to the background application. There might be particular window state/flags that makes it work for you; with Awesome, if I start recording, and then send the Peek window to the background, I can interact with the application that I want to record, but if it's supposed to actually click through to the application behind it then that might require specific support for tiling WMs. For Awesome, I tried to set up rules for the Peek application so that it is floating but not always on top, but I seem to have done something wrong, but if I manually send it to the background then I can interact while it's recording that part of the screen.

djcas9 commented 7 years ago

@phw had a chance to poke around, and it will take custom work to get it to work with i3 correctly (a lot I think). I'm assuming it will be custom for each tiling WM.

Anyhow, will see if I can get a patch for i3 working at least.

dmsmidt commented 7 years ago

@mephux a patch for i3 would be great. But would be even better if it isn't tiling WM specific.

I use: gtk3 3.22.4-1 and i3-wm 4.13-1.

djcas9 commented 7 years ago

@phw @ibrahima @dmsmidt I looked at this for a few days. No idea why it's now allowing it to pass through. I debugged everything I could think of. Super confused on this one. :-\

djcas9 commented 7 years ago

to further elaborate compton is likely the problem but I couldn't pin it down.

phw commented 7 years ago

@mephux Thanks a lot for this investigation, very much appreciated. But looks like there is not much I can do, if it needs probably be addressed in Gtk and/or i3

To be honest tiling window managers are not really the target for Peek. I am happy if it works there, but I probably won't invest time debugging and fixing it myself. I will accept patches, though :)

Closing this for now, feel free to reopen if there is some chance we can get this fixed here.

dmsmidt commented 7 years ago

@mephux thanks for your time, @phw a pitty we can't get this working. Could you mention the known limitations on the project page?

phw commented 7 years ago

I was playing with i3 and sway a bit and also tried it there (actually quite like i3, even though tiling window managers are not my thing in general). Found out this was reported to i3 a few days back: https://github.com/i3/i3/issues/2742 . Fact is that i3 does not support the shape extension, and this was left out somewhat intentional as it is not a typical use case for tiling window managers. Maybe they will consider implementing this :)

On Sway it is a different story. There is some click through behavior, but the clicks are triggered completely off and moving & resizing the peek window is nearly impossible (the entire handling of floating windows seems to be buggy, but sway is work in progress anyway)

phw commented 7 years ago

Also tracked for Awesome WM at https://github.com/awesomeWM/awesome/issues/1827

pciavald commented 7 years ago

Would be interested in this feature too. Switching to another software for now, but i'll gladly come back if the thread is updated.

erayaydin commented 7 years ago

I'm also interesting with this feature. For now, you can use scratchpad. Open peek and set location after starting peek, hide peek to scratchpad. When you finished recording you can get 'peek' from scratchpad. It will record :+1:

But there should be a nice way for recording i3 window with peek.

tmccombs commented 7 years ago

Peek is the best gif screen recorder I have found. I wish it worked better with i3.

grepsedawk commented 6 years ago

So the way to do it is to make both peek and the window you're trying to capture into "floating mode" ($mod + shift + space is default). Put peek just above the window you want to capture and fire away... It's a pain but better than nothing: image

NOTE: compton or equal must be running.

MattMcMurray commented 6 years ago

Furthering @pachonk's point: Stacked ($mod+s) and tabbed ($mod+w) mode also work

grepsedawk commented 6 years ago

@MattMcMurray Nice tip, that's definitely easier than moving all the windows around like an ancient windowed WM

nberrios commented 6 years ago

@pachonk yer a wizard

grepsedawk commented 6 years ago

@nberrios Thanks, I had to do like 3 hours of research over something so small to finally find that... Lol

AndreasBackx commented 6 years ago

Unfortunately if you want to record something like polybar, you cannot easily set it to floating mode.

salmanulfarzy commented 5 years ago

https://github.com/i3/i3/pull/3514 might solve this.

rassie commented 4 years ago

I can confirm that this is actually solved. i3 4.17.1, peek 1.4.0, no compton or scratchpad needed.

akhiljalagam commented 4 years ago

I can confirm that this is actually solved. i3 4.17.1, peek 1.4.0, no compton or scratchpad needed.

worked for me..... :+1:

jc00ke commented 4 years ago

Same here, thank you!

tdakhran commented 3 years ago

I can confirm that this is actually solved. i3 4.17.1, peek 1.4.0, no compton or scratchpad needed.

Works!