search

phw198 / OutlookGoogleCalendarSync

Sync your Outlook and Google calendars
https://www.outlookgooglecalendarsync.com/
Mozilla Public License 2.0
1.83k stars 217 forks source link

Avoid "Sync Failed" modal dialog boxes overwhelm #1150

Open sVathis opened 3 years ago

sVathis commented 3 years ago

When a sync fails for a perfectly valid reason (e.g. no network connectivity) a "Sync Failed" modal dialog box pops up. If the sync is executed frequently (and/or multiple instances of OGCS are running with different parent windows) user is overwhelmed by dialog boxes that are very difficult to close as user need to find and click the parent window in order for the dialog box to come on top before clicking the Yes/No button. image

"Sync failed" messages could be issued inside the main application window, without using a dialog box. Default behavior (try again or not) could be set by a configuration option.

phw198 commented 3 years ago

Looks like a duplicate of #886

sVathis commented 3 years ago

Probably so. Will try hotfix 2.8.5.11 and will let you know.

ik8sqi commented 3 years ago

FYI this is not fixed in 2.8.7.0. When logging in via VPN to our corporate network, the VPN blocks internet access unless a proxy server is configured. When that happens (VPN but no proxy) OGCS has access to our Exchange but does not have access to the internet. That's when the flood of "Sync Failed" popups occurs.

Untitled5

phw198 commented 3 years ago

Looks like the issue might have resurfaced in v2.8.7.

@ik8sqi Please provide your OGcalsync.log file (see instructions) after you have encountered this issue. Thanks

ik8sqi commented 3 years ago

Looks like the issue might have resurfaced in v2.8.7.

@ik8sqi Please provide your OGcalsync.log file (see instructions) after you have encountered this issue. Thanks

Here it is: https://gist.github.com/ik8sqi/ddc9611062439b1c08c8d62abeddead2

phw198 commented 3 years ago

Thanks - and this does look to be different from #886.

:package: Please confirm if this is now resolved with hotfix v2.8.7.1.zip (see instructions for applying).

ik8sqi commented 3 years ago

Nope - no luck. Same issue. https://gist.github.com/ik8sqi/1c476c621b8b6b12db4203a6298cac8d

Roberto

On Jun 27, 2021, at 9:44 AM, Paul Woolcock @.***> wrote:

Thanks - and this does look to be different from #886 https://github.com/phw198/OutlookGoogleCalendarSync/issues/886.

📦 This confirm if this is now resolved with hotfix v2.8.7.1.zip https://github.com/phw198/OutlookGoogleCalendarSync/files/6721678/v2.8.7.1.zip (see instructions for applying https://github.com/phw198/OutlookGoogleCalendarSync/wiki/Reporting-Problems#applying-a-hotfix).

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/phw198/OutlookGoogleCalendarSync/issues/1150#issuecomment-869165955, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABQ773XHULHTLJWXZORNGHTTU4TNPANCNFSM4WBEOOZA.

phw198 commented 3 years ago

That looks like a different test - previously you had already successfully authenticated with Google, then your VPN was down and OGCS could not talk to Exchange. Could you test v2.8.7.1 against this scenario?

Meanwhile, I'll look into the VPN being down making it not possible to authenticate with Google...

ik8sqi commented 3 years ago

This is my setup.

My computer is my personal Macbook. I have a Windows virtual machine running inside my Parallels VM environment. The Windows VM is my "work" computer. It's joined to my work Active Directory and is what I use day-to-day at work. When I'm done working, I "suspend" the Windows VM and will "resume" it the following business day.

For work, sometimes I telework from home, sometime I'm in the office.

When I'm home, the Windows VM connects via VPN to my work network. When this happens, Windows does not have internet access unless I enable to proxy settings in the browser. When I'm in the office, the Windows VM is directly connected to the work network. I then disable the proxy settings so as to have "normal" network/internet access while in the office.

That screenshot is what I sometimes see when I resume the Windows VM. Sometimes it happens when I resume it when arriving in the office, sometimes it happens when I resume it when I start teleworking.

Specifically, this morning's screenshot/logs where from this scenario: Yesterday I was in the office, proxy was disabled, no issues. I suspended the Windows VM machine at the end of the day. This morning I was teleworking from home. I resumed the VM at about 8AM - it had access to my home network and the internet, but not to our Exchange as I was not VPN'd in yet. At 8:06AM start the VPN to connect to the office. There was no internet access until I enabled the proxy sometime later (do not know when - maybe an hour or so).

Roberto

On Jun 29, 2021, at 2:58 PM, Paul Woolcock @.***> wrote:

That looks like a different test - previously you had already successfully authenticated with Google, then your VPN was down and OGCS could not talk to Exchange. Could you test v2.8.7.1 against this scenario?

Meanwhile, I'll look into the VPN being down making it not possible to authenticate with Google...

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/phw198/OutlookGoogleCalendarSync/issues/1150#issuecomment-870838706, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABQ773UUWJI2VZ2BAM6OYZLTVIJWTANCNFSM4WBEOOZA.

phw198 commented 3 years ago

Thanks for the background. So I think we have a couple of test cases:

  1. Internet, no VPN, already authenticated (first reported case): hotfix v2.8.7.1
  2. No internet, no VPN, authentication expired (second reported case): hotfix v2.8.7.3 (includes v2.8.7.1)

:package: I have pulled in the expected fix from #1232 - could you try hotfix v2.8.7.3.zip (see instructions for applying).

Note, Google authentication will expire every hour and OGCS has to refresh the login, which is the second text case.

Please let me know how it goes.

phw198 commented 3 years ago

Any feedback on v2.8.7.3 @ik8sqi?

ik8sqi commented 3 years ago

Hi Paul - sorry, had a very busy week and could not test. I installed the patch now and will resume testing when I resume work Monday.

THanks,

Roberto

On Aug 7, 2021, at 11:25 AM, Paul Woolcock @.***> wrote:

Any feedback on v2.8.7.3 @ik8sqi https://github.com/ik8sqi?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/phw198/OutlookGoogleCalendarSync/issues/1150#issuecomment-894668606, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABQ773RKPOOAKGZBHMPNOETT3VGADANCNFSM4WBEOOZA. Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email.

ik8sqi commented 3 years ago

No luck. Problem still occurs. Log is here: https://gist.github.com/ik8sqi/968fa835c80413308bff1486c13658c2 https://gist.github.com/ik8sqi/968fa835c80413308bff1486c13658c2

The scenario when the error occurred this morning was: I'm teleworking today Windows is connected to corporate network via VPN Exchange is reachable Internet access is not available as there were no proxy settings configured to allow access to the internet (I was in the office yesterday, so the proxy was disabled as we don't use the proxy when physically connected to the corporate network)

On Aug 7, 2021, at 11:25 AM, Paul Woolcock @.***> wrote:

Any feedback on v2.8.7.3 @ik8sqi https://github.com/ik8sqi?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/phw198/OutlookGoogleCalendarSync/issues/1150#issuecomment-894668606, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABQ773RKPOOAKGZBHMPNOETT3VGADANCNFSM4WBEOOZA. Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email.

phw198 commented 3 years ago

Sorry, seemed to have missed this.

:package: New error, additional fix! Please try v2.9.0.8.zip (see instructions for applying) - please ensure you are first running v2.9.0 before you apply this patch.

Please let me know how it goes.