Library is not compatible with java modules

phxql / argon2-jvm

Argon2 Binding for the JVM

GNU Lesser General Public License v3.0

330 stars 32 forks source link

Library is not compatible with java modules #84

Closed ertong closed 3 years ago

ertong commented 3 years ago

There is no module-info.java in argon2-jvm-nolibs package. Moreover Automatic-Module-Name: de.mkammerer.argon2-nolibs which is invalid package name.

As a result, in order to use the library as module it should be repackaged, which is not the best thing to do.

phxql commented 3 years ago

This is fixed in https://github.com/phxql/argon2-jvm/issues/80 which lands in the next release.

phxql commented 3 years ago

Fix is released in >= 2.10.

A248 commented 3 years ago

@phxql Would it be acceptable to PR a multi-release jar which includes module-info in META-INF/versions/11? There are still some benefits to having a full module descriptor (module-info.java) over Automatic-Module-Name. Creating a MRJAR would require building with JDK 11, but runtime compatibility with JDK 6 can still be maintained.

phxql commented 3 years ago

Yes, if you want to help to support JPMS for real, i'll be thankful :)