search

phyce / rl-natural-speech

Text to speech with high quality voices plugin for runelite
BSD 2-Clause "Simplified" License
9 stars 2 forks source link

All messages are spoken regardless of what is selected by the user #10

Closed DingusHammer closed 2 months ago

DingusHammer commented 2 months ago

I only have public messages selected, but I still get system and dialog messages spoken even without them selected. I have attached a screenshot of my settings. Screenshot 2024-04-17 133950

phyce commented 2 months ago

Thanks for letting us know! I think I know what's causing this. expect a fix soon

phyce commented 2 months ago

@DingusHammer I can confirm the dialog messages are still playing even when turned off. I can't replicate any system messages playing when disabled though. Is it some specific system messages that still get played? Please let me know so I can test and see what's going on. I will push the fix now for the dialogues, and if you come back to me with which system messages still get played, I'll look into that further.

DingusHammer commented 2 months ago

@phyce The only system messages I get are examine texts (at least I think those are considered game messages). Also, I am still getting dialog messages though I'm not sure if I need to update things on my end to get the update.

phyce commented 2 months ago

Ahh yes you're right they do still play. those should be disabled by unticking the Examine text option. I have also now fixed that. The update will be automatically downloaded when runelite devs approve the update after reviewing it.

TheLouisHong commented 2 months ago

for reference, fixed in: dc436e6407a83dbabc8422ec646715cff792311e and c3c021cf7e1a707c794385247baae8329dd3a09d in 1.2.1