phyllisstein / alp

A Python module for Alfred v2 workflows
174 stars 11 forks source link

Requests? #3

Closed ahti closed 11 years ago

ahti commented 11 years ago

I am not quite sure how necessary it is to provide a wrapper around Requests. As you write in the readme, Requests is a pretty heavy module. It also already comes with an api that is, imho, really easy to use, so i don't think the wrapper really is of much help.

I think it would be better to maybe give users a hint that Requests is the cool thing to use, but not include it in alp by default.

phyllisstein commented 11 years ago

Hi Ahti, The logic there is twofold. First, during the beta period, the workflows that were coming out made much heavier use of HTTP requests, and so it seemed like a worthwhile addition. I'll be keeping an eye on whether the trend continues to see if Requests should stay or go. But more importantly, anything that does make HTTP requests is going to desperately need requests_cache for speed, and it can't locate Requests if it's dropped into the workflow folder separately. The requests_cache code had to be slightly altered here so that everything would import and monkeypatch smoothly. So there's a tradeoff involved. Since the module is still by no means prohibitively large to pull from Github, and since the compressed alfredworkflow files stil wind up well under 1MB even with it included, I'm inclined to leave it until I see evidence that it's just utterly useless.

Thanks, though, for the feedback! Happy flow-working.