search

phylll / mychs-macro-magic

A simple, sane, and friendly little scripting language for your Roll20 macros.
MIT License
0 stars 0 forks source link

Attack/defense scripts: critical failure (throw of 1) did not fail with skill 19 (but should) #78

Closed phylll closed 7 months ago

phylll commented 8 months ago

Hmmm. This can be fixed right now only for "original" rolls, no repeat rolls. Repeat rolls are faked by calling roll(17) instead of roll("1d20"), which produces a fine roll result value but doesn't produce the right response when handed over to isfumble() (or, I would assume, iscritical()) -- understandably so, since how can those functions know what kind of die was thrown and, therefore, what values would be considered critical successes or fumbles?

phylll commented 8 months ago

Except that 1 is always a fumble, regardless of the die thrown... could isfumble() treat 1 as such?

phylll commented 7 months ago

Temporarily solved by overriding isfumble() in libBasics (in 82a303b42b4a409c850abb48a54738d89f8b7da0)

phylll commented 7 months ago

Fix is part of https://github.com/michael-buschbeck/mychs-macro-magic/pull/224