search

phylo42 / IPK

Inference of phylo-k-mers
MIT License
4 stars 1 forks source link

Include sstream to avoid clang compilation error (osx) #27

Closed blinard-BIOINFO closed 4 months ago

blinard-BIOINFO commented 6 months ago

ipk/src/ar.cpp refuses to compile using clang (bioconda osx image).

17:18:39 BIOCONDA INFO (ERR) /opt/mambaforge/envs/bioconda/conda-bld/ipk_1708708439864/work/ipk/src/ar.cpp:127:36: error: implicit instantiation of undefined template **'std::basic_istringstream<char>'**

This error matches the following stackoverflow discussion, last comment explains that it is a clang issue. https://stackoverflow.com/questions/61735609/implicit-instantiation-of-undefined-template-std-1basic-istringstreamchar

Adding #include <sstream> to ar.cpp solved the issue in my local build in an OSX VM.

@nromashchenko I wait for your approval before applying this as a patch to tag v0.5.0, this will allow me to achieve the bioconda recipe. It has to be unix and osx compatible. Unix tests all passed, just need this last fix for osx.

Any other source file where you used std::basic_istringstream<char>' ?

blinard-BIOINFO commented 6 months ago

The same error actually occured in the checks of my other PR. :p

https://github.com/phylo42/IPK/actions/runs/8021626347/job/21914119765?pr=26
nromashchenko commented 4 months ago

Thanks. I close this pull request because I introduced the same change in 34632c3e in develop. Please do not create pull requests to main as I will not accept them (i.e. create requests only to develop).

main will catch up as soon as we make a new release (soon)