phyloacc / PhyloAcc

PhyloAcc a software to detect the changes of conservation of a genomic region
GNU General Public License v3.0
26 stars 12 forks source link

Data overflow in loading configurations #22

Closed Secretloong closed 4 years ago

Secretloong commented 4 years ago

Hi, line 100 in https://github.com/xyz111131/PhyloAcc/blob/master/SRC/main.cpp you used const int BUFF_SIZE = 1024;

But if the configurations text is longer then 1024 bytes, it would be cause PhyloAcc into an infinite loop in configurations loading. Especialy the species lists are very long or the name is very long. When I edited it to 16384, it works for me.

Just in case, do you think if this edition would effect PhyloAcc results? And, if it is necessary could you fix this limitation?

Best wishes

xyz111131 commented 4 years ago

Thanks for the comment. I don't think it would affect PhyloAcc's result. I'll increase the BUFF_SIZE.

Secretloong commented 4 years ago

Thank you!