Closed gwct closed 2 years ago
This is great, Gregg. I have a few edits to suggest before merging.
The latest commit should address these issues.
V2_GBGC
folder is now src/PhyloAcc-ST-GBGC/
Hu-etal-2019
test
subfolder in the project rootRegarding point 3, adding some way to directly test the PhyloAcc binary is on the TODO list. I was thinking that adding a simple --version
flag would be enough to test the install. Currently, with the conda package, the binary is being tested through the interface with subprocess.run()
, which I think is fine but a built in test would be nice.
If we do include a small test dataset, I'm not sure how that would work with the conda install at this point. We would either have to copy that data somewhere that it can be found in the environment, or provide the full path to the data within the anaconda file system (seems complicated). Alternatively, we could just point users to download test data from the Hu-etal-2019
repo or even an independent test-data
repo. That way the user knows exactly where the data is and can decide if they want it, while we rely on a --version
flag or the interface check to test the conda install.
Re: point 3, a test-data repo might be better as then we can add more stuff to it without it becoming a bit weird to be updating the Hu-etal-2019 repo. But for now let's merge this commit and then we can work on splitting out the pieces that need to move (Hu-etal-2019 and test-data).
This is a major reorganization of the repository to facilitate building from conda and to combine multiple codebases. This is also merges the PhyloAcc-interface code with the main PhyloAcc repo. These changes include: