search

phyloref / jphyloref

MIT License
0 stars 0 forks source link

Added a "webserver" command that provides an HTTP API for reasoning #12

Closed gaurav closed 6 years ago

gaurav commented 6 years ago

Added a "webserver" command that starts a webserver which provides an HTTP API for reasoning over JSON-LD files. These files are internally converted into OWL Ontologies and reasoned over, and then the results are provided in JSON as a dictionary of phyloreference IRIs along with lists of node IRIs they resolved to.

This pull request also cleans up some Eclipse files that shouldn't have been included in the first place.

Ready for review!

hlapp commented 6 years ago

This pull request also cleans up some Eclipse files that shouldn't have been included in the first place.

Don't do this. The only justification is laziness, and the result is needless clutter that makes the review task more difficult than it needs to be. I've fixed this up by moving the responsible commit into a separate PR (#13) off of master, and by removing the commit from this PR. (Learn how to do targeted surgery on your PR!) Merge (using merge or rebase) #13 into master, then (if you want to have the corresponding change be part of the baseline for this PR) rebase this branch to master, then force push.

One of the nice features of Git is that there are nice ways to fix up little oversights we all make here or there while putting together a PR. Let's use those features instead of producing clutter.