search

phyloref / jphyloref

MIT License
0 stars 0 forks source link

Mark failing phyloreferences with unmatched specifiers as TODO #2

Closed gaurav closed 6 years ago

gaurav commented 6 years ago

Recognizes unmatched specifiers in a phyloreference (indicated by the testcase:has_unmatched_specifier object property). Phyloreferences that fail but contain at least one unmatched specifier will be marked as 'TODO' and will not prevent the entire study from passing.

The JAR file produced has been incorporated into phyloref/curation-workflow#11.

I tried to rebase this to master or to squash some of those commits, but fixing differences between this branch and master became extremely complex, because master has changed quite dramatically in #1. I could have resplit this branch and cherry-picked individual changes onto it, but I don't think it's worth it for keeping these few changes separate. I therefore just ended up merging master into this. We can squash this into a single commit when we merge.

hlapp commented 6 years ago

BTW I notice there are no tests. On purpose? If not, create an issue on the tracker?

gaurav commented 6 years ago

Sounds good on the typos and clarity! I'd been using the Curation Workflow to test changes to jphyloref, but I guess we should have our own test suite in here -- filed as #3!