phyloref / jphyloref

MIT License
0 stars 0 forks source link

Fixed incorrect code merged in #17 #29

Closed gaurav closed 5 years ago

gaurav commented 5 years ago

47f84fb2104 introduced some incorrect code, which was then merged into master in PR #17. Since the subsequent commits appeared to work while I was working on them, I think the error was caused by the incorporation of FaCT++ in a separate pull request and the subsequent merge. I could probably have caught this by repulling from master rather than trusting Github's assertion that the merge did not have any problems. It could definitely have been caught if we ran a test suite in Travis with every pull request -- so all the more reason to incorporate a test suite ASAP (#3)!