search

phyloref / jphyloref

MIT License
0 stars 0 forks source link

Rewrote phyloreference testing code #6

Closed gaurav closed 6 years ago

gaurav commented 6 years ago

The current version of the phyloreference testing code had evolved through several different cycles, was badly written, and appeared to not be correctly testing phyloreferences using the expected_phyloreference_named property. I replaced it with cleaner, easier to read code that appears to be testing phyloreferences correctly.

This has now been tested by its incorporation into #9 and it's use in phyloref/clade-ontology#29, so it's ready to be reviewed and merged.

gaurav commented 6 years ago

@hlapp Thanks for the comments! I've fixed everything you suggested except the version number. Let me know if you still think I should change that; otherwise, I'll go ahead and merge this!