search

phyloref / klados

A curation tool to edit test cases for the Phyloref curation workflow
http://www.phyloref.org/klados/
MIT License
2 stars 1 forks source link

Bug: modifying phylogenies should reset reasoning results #141

Open gaurav opened 5 years ago

gaurav commented 5 years ago

Currently, reasoning results are maintained even if the phylogenies change. Whenever the phylogeny changes, the reasoning results should be deleted so that re-reasoning is required

gaurav commented 3 years ago

This may be (partially?) fixed, but more testing is necessary before we can close it for sure.

gaurav commented 9 months ago

Nope, this is still in effect. The problem is that it is trickier than it looks: not all changes to phylogenies or phyloreferences will result in changes in resolution, so it seems like it would be irritating to wipe out resolution every time any change is made to either of them. This is also technically difficult, since the data can be changed in a lot of different places -- for example, phylogenies can be changed:

  1. By renaming individual nodes using the Phylotree component anywhere in Klados.
  2. By editing the Newick string of a phylogeny in the PhylogenyView component.
  3. When a new phylogeny is created is the sidebar.

A simpler solution would be to add the Modified Icon to the "Resolve against phylogenies" button if resolution results currently exist, and have it say something like "Your Phyx file has changed. You should re-run resolution to see if your changes modified resolution." This would not appear unless the user has already clicked on the button once to resolve against phylogenies. What do you think?

gaurav commented 9 months ago