phyloref / klados

A curation tool to edit test cases for the Phyloref curation workflow
http://www.phyloref.org/klados/
MIT License
2 stars 1 forks source link

Improve the Phyx summary page #300

Closed gaurav closed 4 months ago

gaurav commented 1 year ago

Two minor fixes may be needed to the Phyx summary page:

  1. The phyloref table adds a column for each phylogeny, but currently only uses the label of the phylogeny (e.g. "Fig 1 from Brochu 2003"). Is this clear enough, or should we add "Phylogeny: " to the front of the phylogeny label (e.g. "Phylogeny: Fig 1 from Brochu 2003")?

https://github.com/phyloref/klados/blob/ce4e31b1de251ff10a22cbc5b2e17ceb41f73436/src/components/phyx/PhyxView.vue#L105-L107

  1. The phylogeny table refers to the "Description" of each phylogeny, but this field no longer exists. Should we replace this field with the curator notes? Or some other field, such as the source, number of leaf nodes, list of leaf nodes, etc.?

https://github.com/phyloref/klados/blob/ce4e31b1de251ff10a22cbc5b2e17ceb41f73436/src/components/phyx/PhyxView.vue#L214

Screenshot 2023-06-21 at 3 27 21 AM
hlapp commented 1 year ago

Perhaps prefix with "Phylogeny for ..."? But generally yes for using some prefix.

As for the table, it seems the most natural change would be to remove this column from the table as well. I don't think there's a good reason to maintain the number of columns, and as you implicitly suggest, there is no clear reason by which to select from the list of fields that aren't currently reported the particular field to start reporting in the table.