phyloref / phylo2owl

Tool to convert phylogenies to OWL ontologies
MIT License
4 stars 2 forks source link

SHACL testing #13

Closed gaurav closed 7 years ago

gaurav commented 7 years ago

Provides a Java class that interfaces with TopBraid's SHACL library to validate an RDF/XML file against a file containing SHACL space. Also includes a Python script that can be called by py.test to run validations correctly and to report the result.

This is pretty complicated, so it might be easier to consider two other options:

gaurav commented 7 years ago

The idea with sending the output to stderr was to ensure that stdout was always well-formed Turtle: I didn't want any error messages getting in there!

hlapp commented 7 years ago

The idea with sending the output to stderr was to ensure that stdout was always well-formed Turtle: I didn't want any error messages getting in there!

Right, but announcing success isn't an error message 😄

gaurav commented 7 years ago

@hlapp: I got rid of the STDERR stuff and the sudo, and I managed to set up Maven so that it creates a JAR file containing all the prerequisites it needs. I still need to build testShacl.jar locally, rather than on Travis, but I've filed that issue for another day: https://github.com/phyloref/phylo2owl/issues/14

hlapp commented 7 years ago

Great, nice work, @gaurav! There's a lot of commits here now of all the trials and errors. I can just squash the whole PR into a single commit ("squash and merge"), or if you want to retain specific commits, you can do an interactive rebase squashing what can be squashed and keeping commits as individual ones as you would like.

Let me know. By default I would squash into a single commit and merge.

gaurav commented 7 years ago

Yup, let's squash and merge it. The largest changes are the source files needed by the SHACL library; the others are mostly small files, and each file should be pretty straightforward to understand.