search

phyloref / phyloref-ontology

Phyloreferencing Ontology and OWL DL reasoning with phyloreferences
Creative Commons Zero v1.0 Universal
5 stars 1 forks source link

Changes phyloref imports to use versionIRI #31

Closed hlapp closed 5 years ago

hlapp commented 5 years ago

This is to isolate the examples from the pending (and future) new version(s) of the Phyloref Ontology that might be incompatible with how it is being used here.

hlapp commented 5 years ago

@gaurav you may want to do this too in generating the clade ontology if you want to isolate yourself from the upcoming changes for cases where you need to adapt the code.

gaurav commented 5 years ago

Done! I've also created issues to replace the Phyloref Ontology URI we've been using with a version IRI, so our code won't break every time the Phyloref Ontology is updated (phyloref/curation-tool#124, phyloref/clade-ontology#53, phyloref/jphyloref#42).

hlapp commented 5 years ago

@gaurav just keep in mind that you only change the ontology IRI you import. Don't change the namespace declaration.

If this is confusing, note that it's the same as when you resolve a non-resolving import IRI to a local file on disk. Doing so doesn't somehow change the namespace to the local file on disk.

Another way of saying this is that a term from two different versions of the ontology isn't two entirely different terms. They would be though if they had different IRIs.

gaurav commented 5 years ago

@hlapp Yup, I know! I screwed up on phyx.json because I got confused between the imports (which should be the version IRI) and the prefix (which should be the base IRI). I just double-checked my change to phyx2ontology and didn't mess it up there, so I can confirm that I'm only an idiot some of the time.

hlapp commented 5 years ago

Ah, no worries. I find myself an idiot many times. You're in good company.

ncellinese commented 5 years ago

I fit the group perfectly!! 😆

On Dec 20, 2018, at 4:09 PM, Hilmar Lapp notifications@github.com wrote:

Ah, no worries. I find myself an idiot many times. You're in good company.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/phyloref/phyloref-ontology/pull/31#issuecomment-449136115, or mute the thread https://github.com/notifications/unsubscribe-auth/ACaXwQRfh7HI4btfz1D82Yih-ROnwUeQks5u6_yJgaJpZM4ZcVmI.