search

phyloref / phyloref-ontology

Phyloreferencing Ontology and OWL DL reasoning with phyloreferences
Creative Commons Zero v1.0 Universal
5 stars 1 forks source link

Fixes and improvements for Maximum / Minimum Clade subclasses of Phyloreference #36

Closed hlapp closed 3 years ago

hlapp commented 3 years ago

Fixes #34, confusion of minimum and maximum clade definitions. Also adds logical definitions for these Phyloreference subclasses.

hlapp commented 3 years ago

Any comments @gaurav ?

hlapp commented 3 years ago

Actually this is problematic in the current model because for a minimum clade definition the phyloreference nod has neither _includesTU nor _excludesTU property restrictions; instead, it has a _hasChild restriction.

So I suspect this is not useful for PhyloreferenceUsingMinimumCladeDefinition.

hlapp commented 3 years ago

Maybe it's actually OK with the new proposed model. I'll leave it in for now.

gaurav commented 3 years ago

Will the use of ObjectComplementOf in the definition of PhyloreferenceUsingMinimumClade take us out of OWL 2 EL? Apart from that, this looks good to me!

hlapp commented 3 years ago

It does, but if the axiom doesn't matter for our primary reasoning goals, that need not be a show stopper, because most EL reasoners will simply ignore axioms not in EL.

I should add that the axiom also isn't really appropriate anymore, so I'll be changing that to _has_Child some (excludes_TU some TU and includesTU some TU).