phylotastic / Pt_Mobile_Application

Mobile Application for Phylotastic Project
2 stars 0 forks source link

De-clutter tree view #56

Closed arlin closed 8 years ago

arlin commented 8 years ago

De-clutter tree view by removing internal node labels and ottIds, as described in design/mobile_app_mvp_priorities.pptx

thanhnh-infinity commented 8 years ago

Removed open tree ottids in tree is done right now.

But I do not know how to remove internal node, because when I receive the newick tree from Web Services. They are existed. So I think we should remove them from server-side ?

And If Yes, How can we remove them ?

arlin commented 8 years ago

we should find or develop toolbox code to do this, but if you just want a quick fix, I would suggest to use regular expressions-- probably something like s/)[^),;]+/)/g will remove them. Any name following a right parenthesis is an internal node name, and they will always be followed by either a comma or another right parenthesis or semi-colon if that's the end of the tree-string.

thanhnh-infinity commented 8 years ago

Oh, that is good suggestion. I will try to do follow your guide.

thanhnh-infinity commented 8 years ago

Fixed, I used /)[a-z|A-Z]+/g

arlin commented 8 years ago

My tests indicate that this is fixed. Thanks!