search

phylotastic / Pt_Mobile_Application

Mobile Application for Phylotastic Project
2 stars 0 forks source link

tree view cut off at bottom #73

Closed hdliv closed 7 years ago

hdliv commented 8 years ago

i wasn't able to reproduce this but wanted to document it in case we see it again. We should be able to export both our list of species and tree . I will create another issue for exporting list.

located here: Pt_Mobile_Application/test/images/odd_tree.jpg

arlin commented 8 years ago

I have seen this behavior as well, and I think this is related to #75. In #75 this is described as a problem with a larger tree. However, perhaps it is simply the case that the viewer is choosing the wrong frame size and fails to show the branch at the bottom of the tree image.

hdliv commented 8 years ago

in #67 I also speak of this behaviour

arlin commented 8 years ago

In the attached image, you can see that this is a matter of the frame being off, because the upper part of the missing name is visible (circled area) frame_issue

hdliv commented 8 years ago

@arlin when i export to browser, the full tree with no cut-off is viewed

thanhnh-infinity commented 8 years ago

Yes @hdliv , It is only in app. I am trying to fix it. But unfortunately, it is issue that comes from origin jsphylosvg library. So, I need to do some more researches in the case we are continue using jsphylosvg There are some references links: https://jsphylosvg.uservoice.com/forums/55902-general/suggestions/7252947-clear-and-reload-tree http://stackoverflow.com/questions/30667884/why-is-the-bottom-of-the-figure-cut-off

hdliv commented 8 years ago

@thanhnh-infinity thanks for the explanation

hdliv commented 8 years ago

moving this since we have identified the problem. is that ok @thanhnh-infinity

arlin commented 8 years ago

I posted a comment about this on the jsphylosvg site. I also wrote to the author. I met him when he first presented a demo of jsphylosvg at iEvoBio.

arlin commented 8 years ago

Sorry for not following up on this. SS (original developer) wrote back to me and says "If you're able to generate a page that reproduces this for me that would be very helpful.

Have you by any chance tried to adjust the height property? "

thanhnh-infinity commented 8 years ago

I have not changed the height property. jsphylosvg is javascript, works only on Web. In order to work on our mobile app, I had to re-code everything based on jsphylosvg features because the app's language in iOS is Objective-C and Android is JAVA. I tried to search solution but I think it is not solved yet. I sent link to download our application to the author.

hdliv commented 8 years ago

@thanhnh-infinity thank you. I received the notice.

arlin commented 7 years ago

I do not see this problem anymore. @hdliv, are you still seeing this?

hdliv commented 7 years ago

@arlin OK for me

arlin commented 7 years ago

closing