search

phylotastic / phylotastic-portal

Web tool (ruby on rails) providing access to phylotastic services for acquiring species trees.
https://github.com/phylotastic/phylotastic/wiki
1 stars 3 forks source link

DateLife error not trapped in portal #339

Open arlin opened 6 years ago

arlin commented 6 years ago

See #335 for examples of lists that give large trees of about 500 tips. In both cases we get an error from DateLife below.

Detect this error and provide an informative error message to the user.

screen shot 2018-09-05 at 8 14 50 pm
ducvan0212 commented 6 years ago

@LunaSare what should I display in portal? Can you provide an understandable message so I will put it in the portal?

ducvan0212 commented 6 years ago

{"message": "Error: 'results'"}

This is what I got from DateLife scaling service for Brian's sample tree in #335 .

LunaSare commented 6 years ago

For the first error, something like "There is not enough information to scale this tree with DateLife" Let me check what's generating the second error...

ducvan0212 commented 5 years ago

@LunaSare

LunaSare commented 5 years ago

I'm sorry @ducvan0212, it took my a long time to debug this one. But we found the source of error. It should be working now.

Answering your original question, the most common case in which we're not gonna be able to obtain a chronogram with median or sdm is: "There is not enough time information in databases to get a summary chronogram for this set of taxa." However, this is a long message and there could be other types of errors. So I think the best option will be to put a more general and short message, to simply indicate that these trees are not available, such as "Unavailable", or simply gray out those options any time DateLife throws an error.

What do you think @bomeara?

ducvan0212 commented 5 years ago

Anyway, I made the message display as a tooltip. You can check it out from dev server.