search

phylum-dev / cli

Command line interface for the Phylum API
https://phylum.io
GNU General Public License v3.0
103 stars 11 forks source link

Move submit package API types to CLI and add vuln data. #1314

Closed mathew-horner closed 10 months ago

mathew-horner commented 10 months ago

In favor of https://github.com/phylum-dev/phylum-types/pull/86, I've moved the PackageSubmitResponse and all its child types from phylum-types to CLI. I've updated any other code that was referencing these types to the local instances.

Unfortunately a couple From impls were necessary to maintain compatibility with the code that still is using PackageStatusExtended... I guess I could move that too, but I didn't because it's out of scope for the main purpose of this PR.

closes https://github.com/phylum-dev/cli/issues/1313

mathew-horner commented 10 months ago

In order to test these changes, you'll need to point your CLI at staging. The API changes have not been cut to prod yet (deserialization will still succeed since it's an optional field, you just won't see it).