phylum-dev / cli

Command line interface for the Phylum API
https://phylum.io
GNU General Public License v3.0
101 stars 10 forks source link

ci: remove trigger for `homebrew-cli` formula bump #1362

Closed maxrake closed 6 months ago

maxrake commented 6 months ago

The trigger is no longer needed now that:

Some documentation updates were made to be more consistent in wording.

Checklist

maxrake commented 6 months ago

What's our transition plan for users that already have the CLI installed from our tap? Do we need to maintain both for a while?

The current plan is to keep the custom tap around for a little while longer, updating it (at least one more time) to follow the guidance from Homebrew Documentation on "Deprecating, Disabling, and Removing Formulae".

Using the disable! call is the preferred method since it will be the most obvious to users, but using the deprecate! call is also possible. In either case, a custom reason will be provided to make it clear that the tap should be swapped out for the homebrew core phylum-cli formula. Perhaps a link to the docs/README would be helpful so that a full set of "conversion" steps can be provided while the reason is kept short.

maxrake commented 6 months ago

The transition plan has been better outlined in this comment.

If that plan is acceptable, then this PR can proceed after the one to deprecate the custom formula is complete.

UPDATE: The custom phylum formula is now deprecated.