search

phylum-dev / cli

Command line interface for the Phylum API
https://phylum.io
GNU General Public License v3.0
99 stars 10 forks source link

Remove deserialization of `owner_email` and `is_owner fields` in group listing structures #1375

Closed mathew-horner closed 4 months ago

mathew-horner commented 4 months ago

These fields are going away soon: https://github.com/phylum-dev/api/issues/1266

We probably will need some sort of transitionary period here, so we don't break phylum group list on older versions. I was thinking that we could return is_owner always set to false and maybe something like "<deprecated>" for the owner email, and that will get displayed in the groups table in older versions of the CLI. What do you guys think?

mathew-horner commented 4 months ago

This should be fine, but my main concern here is that we're removing something without integrating the replacement for it.

Have you put in any thought on if or how the admin user role should be represented in the CLI?

The structure still includes is_admin. I think we probably want to replace that with a role field eventually, like we did for the group member list endpoint, for the same forward compatability reasons.

cd-work commented 4 months ago

The structure still includes is_admin. I think we probably want to replace that with a role field eventually, like we did for the group member list endpoint, for the same forward compatability reasons.

Do you have any plan to show this information in the group list table?

mathew-horner commented 4 months ago

The structure still includes is_admin. I think we probably want to replace that with a role field eventually, like we did for the group member list endpoint, for the same forward compatability reasons.

Do you have any plan to show this information in the group list table?

I don't, but we could probably add it fairly easily. Maybe after we add a role to this response we can display their role in each group in the table?