search

phylum-dev / community-extensions

A collection of community extensions for the Phylum CLI
https://www.phylum.io/
GNU General Public License v3.0
1 stars 1 forks source link

feat: add support for additional Python location on macOS #20

Closed maxrake closed 1 year ago

maxrake commented 1 year ago

This PR adds another, default, location on macOS for where the python binary can live.

louislang commented 1 year ago

This alone didn't seem to fix it on my end. My machine only has pip at pip3. I'm not sure if this is standard on MacOS, but I don't believe I've installed it separately. Changing all references of pip to pip3 did seem to fix it with these changes though.

We should consider updating the UX here, such that a failure to find pip explicitly states that pip could not be found.

maxrake commented 1 year ago

This alone didn't seem to fix it on my end. My machine only has pip at pip3. I'm not sure if this is standard on MacOS, but I don't believe I've installed it separately. Changing all references of pip to pip3 did seem to fix it with these changes though.

We should consider updating the UX here, such that a failure to find pip explicitly states that pip could not be found.

Well...this just got more complicated...more than I can handle, anyway, in a reasonable time frame. I can close this PR or have @cd-work take it over.

maxrake commented 1 year ago

The other part of the solution for getting this extension working is in #21

maxrake commented 1 year ago

We should consider updating the UX here, such that a failure to find pip explicitly states that pip could not be found.

This is related to https://github.com/phylum-dev/cli/issues/781, which is a CLI issue. This community extension PR can proceed without this fix for now.