search

phylum-dev / community-extensions

A collection of community extensions for the Phylum CLI
https://www.phylum.io/
GNU General Public License v3.0
1 stars 1 forks source link

Add CODEOWNERS file #3

Closed kylewillmon closed 2 years ago

kylewillmon commented 2 years ago

I assume @phylum-dev/integrations will handle this repository.

kylewillmon commented 2 years ago

I am also second guessing this PR. Extensions can (and should) be written by just about anyone, so perhaps the write access to this repository should be every Phylum employee and any 2 code reviewers is fine. That may be why @louislang didn't add a CODEOWNERS file from the start.

louislang commented 2 years ago

Yeah, that was basically the idea @kylewillmon. I tried to add the entire Phylum org, but Github wouldn't let me do that. I think we can also just limit pushes to main to a handful of people (integrations being in that group).

louislang commented 2 years ago

Updated to give phylum-dev/integrations write permissions on this repository. So should be good to merge this in. Might take a second for that change to be reflected on this PR though.

kylewillmon commented 2 years ago

Updated to give phylum-dev/integrations write permissions on this repository. So should be good to merge this in. Might take a second for that change to be reflected on this PR though.

If the idea is that the whole org owns this repo, then I think it makes more sense to go without a CODEOWNERS file.