search

phylum-dev / community-extensions

A collection of community extensions for the Phylum CLI
https://www.phylum.io/
GNU General Public License v3.0
1 stars 1 forks source link

chore: Create CODEOWNERS #9

Closed furi0us333 closed 2 years ago

furi0us333 commented 2 years ago

This was previously rejected in #3 ...

See this comment.

Has something changed?

@kylewillmon I missed that, but the problem is that it doesn't assign anyone. If Integrations is not correct, maybe I can just use Engineering to broaden the owner group so it still auto-assigns ppl?

kylewillmon commented 2 years ago

maybe I can just use Engineering to broaden the owner group so it still auto-assigns

I would support that. I think you can even configure the engineering group so that it assigns 2 reviewers (as required by this repo) instead of just one.

But we haven't found a fix to GitHub notifying everyone in the group ... So having a large group there may get annoying. Time will tell