phyphox / phyphox-android

Physical Phone Experiments
GNU General Public License v3.0
319 stars 42 forks source link

Add light theme #26

Closed xmha97 closed 1 year ago

xmha97 commented 2 years ago

Hi, thanks for this app. Please add light theme.

Staacks commented 2 years ago

I have put this on my todo list to think about it. The problem here is that this might be problematic in some edge cases with custom experiment configurations where the user defined a font color and/or separator color which is not from our default color palette. I think that we could work around this and that it would not be too much work, but since it still is "some" work and since the dark color scheme has become something quite recognizable, I am wondering why you need this?

In my experience a missing dark theme is much more problematic except for presentation on projectors. The remote access actually got a light mode for this reason. So, what is your use case, so we can understand it?

xmha97 commented 2 years ago

Thanks for your explanation but all the apps I installed have both a dark theme and a light theme. I always use the light theme because I'm more comfortable with it.

Staacks commented 2 years ago

ok, that's low priority then, but I can see how it would be nice if it was consistent with the behavior of the OS and other apps.

xmha97 commented 2 years ago

After adding the light theme, it would be great if this feature was also added:

lgommans commented 1 year ago

I hadn't really identified phyphox as having a "dark theme". I guess the theme has the property of being dark by nature, but to me it's just phyphox' own custom look as it is. Personally, I wouldn't need a special bright background color for any reason. Sometimes in direct sunlight a light theme can help (my old Huawei LCD would increase screen contrast when the backlight was already at the max and the sensor told it there was still more light, and that did help), but I haven't had the issue with phyphox that something was hard to read under any condition.

Staacks commented 1 year ago

Thanks. The main reason we keep this on our todo list is the use in schools. Not because of readability on screen (although that can be an issue if the phyphox interface is streamed to a projector) but on a print-out. Worksheets are often handed out as a print-out and students tend to document their work with a screenshot from the app in a similar way. Here a light version would be quite helpful.

xmha97 commented 1 year ago

Thanks for adding the light theme.

Screenshot_2023-08-22-22-39-36-436_de rwth_aachen phyphox

Please set the "System" as default theme.

Staacks commented 1 year ago

Please set the "System" as default theme.

There are several reasons that we did not set this as the default:

So, why do you care about the default when you can set it to your personal preference? Anyone who cares can easily set it, but for most users who do not care, the dark theme is the better option.