phys201 / Hamiltonian-photonic-crystal

Build the Hamiltonian model to reproduce the band structure measured on photonic crytal
GNU General Public License v3.0
0 stars 1 forks source link

consider moving functions into a .py file #29

Closed erandichavez closed 1 year ago

erandichavez commented 1 year ago

Consider the functions and classes in your documentation notebook (ham2, my_gausslike, Peak_Position, etc...) into a .py file in your package and then load them in. This will save space and make your documentation notebook more readable.

thaodinh98 commented 1 year ago

We did move all of these into the Model.py. Probably we didn't clearly say where we used it in the notebook, we will rewrite the documentation notebook to make it clearer.