search

physical-computation / Warp-firmware

Firmware for the Cambridge Physical Computation Laboratory's Warp Embedded Multi-Sensor Platform.
http://physcomp.eng.cam.ac.uk
BSD 3-Clause "New" or "Revised" License
5 stars 198 forks source link

Replace use of magic numbers in drivers with named constants #86

Open phillipstanleymarbell opened 4 years ago

phillipstanleymarbell commented 4 years ago

For example, the values we use for setting the ctrl_meas register for the BME680

For example, the literal constant 0b00000001 in

https://github.com/physical-computation/Warp-firmware/blob/098faa05ad43396a1ad096361f5734bb2d3a6791/src/boot/ksdk1.1.0/warp-kl03-ksdk1.1-boot.c#L2535)

should be named constants (e.g., kWarpDevBME680HumidityOversampling1x or something better, to be defined in the corresponding driver header file).