physical-computation / sunflower-embedded-system-emulator

Sunflower Full-System Hardware Emulator and Physical System Simulator for Sensor-Driven Systems. Built-in architecture modeling of Hitachi SH (j-core), RISC-V, and more.
http://sflr.org
BSD 3-Clause "New" or "Revised" License
23 stars 215 forks source link

The constants in the enum should be named based on the coding conventions #174

Open phillipstanleymarbell opened 4 years ago

phillipstanleymarbell commented 4 years ago

The constants in the enum should be named based on the coding conventions (e.g., kSunflowerInstructionLatencyIndexIF) to make their use left confusing, since the pipeline structure (P) also has fields called IF, ID, etc.)

https://github.com/physical-computation/sunflower-simulator/blob/e414503efde31eeec176b375a8522353f14d2165/sim/mextern.h#L46