physiopy / phys2bids

Python3 library to format physiological files in BIDS. At the moment, it supports Acqknowledge and Labchart. BrainHack participants, check the issues with the BrainHack labels!
https://phys2bids.readthedocs.io
Apache License 2.0
64 stars 44 forks source link

Add support for files without header #143

Open smoia opened 4 years ago

smoia commented 4 years ago

Detailed Description

41 was closed trough a couple of PRs, but we don't support txt files without header yet.

We decided that it's not important before our main release, so this issue is to remind us that we'll have to do it, but it's definitely not fundamental.

Possible Implementation

Either we add a lot of optional arguments for the command line, or we read a file that contains such information - maybe another script could help the user create this file (a json?)

vinferrer commented 4 years ago

I would close the issue, either adding optional arguments or the second option of reading a different file is too costly for the reward

smoia commented 4 years ago

Let's not close the issue, and kep it to remind us that there is this enhancement we can work on at a later date - that's the meaning of the label "Paused". If we can add a way to automatically recognise the channels, it will become a bit easier to deal with this problem as well.