physiopy / phys2bids

Python3 library to format physiological files in BIDS. At the moment, it supports Acqknowledge and Labchart. BrainHack participants, check the issues with the BrainHack labels!
https://phys2bids.readthedocs.io
Apache License 2.0
65 stars 45 forks source link

How compares to mriphysio ? #438

Open yarikoptic opened 1 year ago

yarikoptic commented 1 year ago

I was told about https://github.com/adolphslab/mriphysio by @jmtyszka.

My greedy rationale: We are considering a Siemens WiP to package/send physio data as DICOMs. Now need to figure out what would be the best tool for us to do then conversion from DICOMs, hence "shopping around".

smoia commented 1 year ago

Hey there,

we don't support SIEMENS physiological data yet. I'd say that the first step was to adapt the workflow to read files from MRIs in general (mainly because they lack a trigger but they are coherent with the runs, which is not the case for everything else). @nw-duncan covered it for GE files. So we can now integrate a SIEMENS conversion system as well. I'd be very happy if @jmtyszka you'd like to help us with it! Alternatively, I think @marcelzwiers has another method we could try to integrate - and maybe we need to integrate both, as they might be for different SIEMENS data structures.

marcelzwiers commented 1 year ago

Hi there, what I implemented was the physio data of the CMRR puls-sequence (which is a custom-made sequence for Siemens scanners), I don't know about the Siemens product sequence

yarikoptic commented 1 year ago

and I forgot to ask @pvelasco about https://github.com/cbinyu/bidsphysio -- would that one work on "stock" Siemens WiP DICOMs?